[SCIM 4.1/4] List users and groups in a single query #9325
+411
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-crespo
changed the title
david-crespo
force-pushed
the
scim-list-users
branch
from
6f4977f to
1c5ddcd
Compare
papertigers
reviewed
Oct 31, 2025
|
|
||
| async move { self.list_users_in_txn(&conn, err, filter).await } | ||
| }) | ||
| .list_users_with_groups(&conn, err.clone(), filter) |
There was a problem hiding this comment.
hmm I think doing this in a txn is load bearing, is that right @jmpesp ?
There was a problem hiding this comment.
I thought it was only because there were 50 queries in there. It can easily be put back.
This test verifies that listing groups via the SCIM API correctly includes member information for each group, including groups with multiple members, groups with a single member, and groups with no members. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Rewrites list_groups_in_txn as list_groups_with_members to use a single query that fetches both groups and their members in one database roundtrip. This uses a LEFT JOIN to the silo_group_membership table and aggregates the results in application code, similar to the list_users_with_groups implementation. The transaction wrapper is removed since it's no longer needed - the function now performs a single read-only query. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
david-crespo
force-pushed
the
scim-list-users
branch
from
1c5ddcd to
fc8cd1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added integration test for existing implementation, change implementation, test continues to pass. Let's definitely give the logic a close look, I did not exactly write it.
Assembling the users and groups into the final shape is done in Rust code. I don't know if there's any way around that.